All PR's approved and merged at end of every sprint
I realize this is concerning but looking for a sanity check on whether it's a yellow, orange, or red flag. I work for a "tech" company. We sell software, that is our only revenue source, not an internal tools team for some boomer legacy non-tech corp.
At the end of each sprint, all outstanding PR's are approved and merged into main, regardless of whether changes were requested, if it's in draft status it will get changed to open and then merged.
Not minor changes or disagreements on variable names, pretty big concerns such as:
- This uses a different dependency version than the rest of our repo
- This redefines a function in our existing codebase because you like the way you do it better
- This code does not work, it raises 5 different exceptions
- I literally have no idea if this code works because it's written in an entirely different language than the rest of our codebase and we don't even have a way to run it
This isn't a case of "junior doesn't understand that software is complex" ergo backend, frontend, analytics all using different languages. Last sprint, we all worked on a simple feature that calls an API, writes data to s3, writes data to a database. We ended up with a python file, a shell script, a Dockerfile (uses a different version of python but it's main feature is that it defines it's own linting and pre-commit and overrides the repo config which is admittedly pretty funny) and a Kotlin file. We are not a Kotlin shop, I have no idea how they even wrote it. Everyone called the same API, wrote to the same bucket and database, and we all did it differently.
I work on a 6 person team, so basically every sprint we end up with 6 more pieces of a feature that either don't work at all, or don't fit with anything. There is vague talk about getting it to fit together later.