u/uyvhtvuyg

Hi, I am still learning how to become a developer, and in my node.js express application, I have a controller that exports functions that are created using factory functions.

The factory functions are as follows in this module:

const asyncHandler = require('../utils/asyncHandler');
const AppError = require('../utils/AppError');


exports.getData = (Model) =>
  asyncHandler(async (req, res, next) => {
    const document = await Model.findAll();
    res.status(200).json({
      status: 'success',
      results: document.length,
      data: {
        document,
      },
    });
  });


exports.createData = (Model) =>
  asyncHandler(async (req, res, next) => {
    const document = await Model.create(
      req.body,
      //object?
    );


    res.status(201).json({
      status: 'success',
      message: 'entry added successfully',
      data: {
        document,
      },
    });
  });


exports.deleteData = (Model) =>
  asyncHandler(async (req, res, next) => {
    await Model.destroy({
      truncate: true,
    });


    res.status(204).json({
      status: 'success',
      data: null,
    });
  });


exports.updateData = (Model) =>
  asyncHandler(async (req, res, next) => {
    const document = await Model.update(req.body, {
      where: { id: req.params.id },
    });


    if (document[0] === 0) {
      return next(new AppError('No document with that ID found.', 404));
    }


    res.status(200).json({
      status: 'success',
      data: { document },
    });
  });


exports.getSingle = (Model) =>
  asyncHandler(async (req, res, next) => {
    const document = await Model.findOne({
      where: { id: req.params.id },
    });


    if (document[0] === 0) {
      return next(new AppError('No document with that ID found.', 404));
    }


    res.status(200).json({
      status: 'success',
      data: { document },
    });
  });

then, in my controller module:

const factory = require('./factory');
const Master = require('../models/masterModel');
// a whole bunch of models are imported

exports.getModel = factory.getData(Model);
exports.createModel = factory.createData(Model);
exports.deleteModel = factory.deleteData(Model);
exports.updateModel = factory.updateData(Model);
exports.getSingleModel = factory.getSingle(Model);

// another 30 of the same thing, for each model that I import at the top of the file... 

How would I refactor this? It is incredibly repetitive and I'm pretty sure this would be unacceptable in a professional environment.

Thanks in advance! :)